Sync webui #441
Merged
Sync webui #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-pbarton
requested changes
Jul 30, 2024
isc-pbarton
requested changes
Jul 30, 2024
|
@isc-pbarton I kept the name of the function to disable the input and moved the call to the hyperevent back to the onClick so no rename is needed |
isc-tleavitt
reviewed
Aug 6, 2024
| </html> | ||
| <script method='OnPreHTTP' language='cache' runat='server' returntype='%Boolean'> | ||
| try { | ||
| set %session.UseSessionCookie = 1 // Always set back to autodetect |
There was a problem hiding this comment.
It would be worth refactoring this to a shared method somewhere since many places use it. Doesn't need to happen in this PR though.
isc-tleavitt
approved these changes
Aug 6, 2024
|
Can retarget to main. |
isc-pbarton
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415
New simple UI flow for the Sync operation